vdk-core: Add python version disparity warning#2242
Merged
Conversation
dakodakov
approved these changes
Jun 13, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/control-cli-cleanup
branch
from
16bf236 to
8e9d09a
Compare
If a user has set a specific python_version in their data job's config.ini file, but they develop the data job in a python environment with a different version, the execution results may be unexpected when the job is deployed. This change adds a warning message for local data job executions, in case there is a disparity between the configured python version and the python environment that executes the job. Testing Done: Locally tested with a data job, and verified the message appears when there is a python version disparity. Signed-off-by: Andon Andonov <andonova@vmware.com>
doks5
force-pushed
the
person/andonova/control-cli-cleanup
branch
from
8e9d09a to
310b1e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user has set a specific python_version in their data job's config.ini file, but they develop the data job in a python environment with a different version, the execution results may be unexpected when the job is deployed.
This change adds a warning message for local data job executions, in case there is a disparity between the configured python version and the python environment that executes the job.
Testing Done: Locally tested with a data job, and verified the message appears when there is a python version disparity.