vdk-jupyter: Fix job creation#2245
Merged
gabrielgeorgiev1 merged 15 commits intomainfrom Jun 14, 2023
Merged
Conversation
…on/gageorgiev/jupyter-creatae
…k step Currently, when creating a job through the jupyter UI, the created job has a sql step and a python step. We'd like a job created that way to have only a notebook inside, as steps will be contained within that notebook. This required changes to both the control cli module, as well as the jupyter python module. An alternative way was possible which left the control cli untounched, however that path was not chosen since it would require patching module namespaces during runtime, which is prone to bugs and is to be avoided if possible. Testing done: tested locally by creating a new job through jupyter UI and observing the notebook step inside Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-creatae Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-creatae
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
…on/gageorgiev/jupyter-creatae Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
Currently, the job creation logic is faulty and the sample job is positioned in the wrong place in the plugin. Testing done: locally Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
duyguHsnHsn
approved these changes
Jun 13, 2023
antoniivanov
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the job creation logic is faulty and the sample job
is positioned in the wrong place in the plugin.
Testing done: locally
Signed-off-by: Gabriel Georgiev gageorgiev@vmware.com