vdk-core: Add python_version configuration to config-help#2271
Merged
Conversation
gabrielgeorgiev1
approved these changes
Jun 15, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/vdk-config-help
branch
2 times, most recently
from
ad15c8e to
e591c94
Compare
As part of the initiative to support multiple python versions for data job deployments, a new configuration property, `python_version` was introduced. This configuration, however, was not initially added to the output of the `vdk config-help` command. This change adds the `python_version` configuration to the JobConfigIniPlugin, as it is related to the config.ini file setup. Testing Done: Tested locally by running `vdk config-help` and verifying that the configuration is present in the output. Signed-off-by: Andon Andonov <andonova@vmware.com>
antoniivanov
approved these changes
Jun 16, 2023
doks5
force-pushed
the
person/andonova/vdk-config-help
branch
from
e591c94 to
a20bc33
Compare
murphp15
pushed a commit
that referenced
this pull request
Jun 21, 2023
As part of the initiative to support multiple python versions for data job deployments, a new configuration property, `python_version` was introduced. This configuration, however, was not initially added to the output of the `vdk config-help` command. This change adds the `python_version` configuration to the JobConfigIniPlugin, as it is related to the config.ini file setup. Testing Done: Tested locally by running `vdk config-help` and verifying that the configuration is present in the output. Signed-off-by: Andon Andonov <andonova@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the initiative to support multiple python versions for data job deployments, a new configuration property,
python_versionwas introduced. This configuration, however, was not initially added to the output of thevdk config-helpcommand.This change adds the
python_versionconfiguration to the JobConfigIniPlugin, as it is related to the config.ini file setup.Testing Done:
Tested locally by running
vdk config-helpand verifying that the configuration is present in the output.