control-service: secrets service unit tests#2276
Merged
Conversation
Add unit tests for the secrets service. Minor code changes to address redundancies, feedback from previous review. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Fix codacy checks. Signed-off-by: Dako Dakov <ddakov@vmware.com>
...ol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultJobSecretsService.java
Outdated
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultJobSecretsService.java
Outdated
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultJobSecretsService.java
Outdated
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultJobSecretsService.java
Outdated
Show resolved
Hide resolved
...ol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultJobSecretsService.java
Outdated
Show resolved
Hide resolved
...s_control_service/src/test/java/com/vmware/taurus/secrets/DataJobsSecretsControllerTest.java
Show resolved
Hide resolved
Address review feedback Signed-off-by: Dako Dakov <ddakov@vmware.com>
antoniivanov
approved these changes
Jun 19, 2023
mivanov1988
reviewed
Jun 19, 2023
...ol_service/src/main/java/com/vmware/taurus/secrets/controller/DataJobsSecretsController.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Jun 19, 2023
...ol_service/src/main/java/com/vmware/taurus/secrets/controller/DataJobsSecretsController.java
Outdated
Show resolved
Hide resolved
mivanov1988
approved these changes
Jun 19, 2023
Fix codacy checks. Signed-off-by: Dako Dakov <ddakov@vmware.com>
…c/main/java/com/vmware/taurus/secrets/controller/DataJobsSecretsController.java Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
…c/main/java/com/vmware/taurus/secrets/controller/DataJobsSecretsController.java Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
mivanov1988
added a commit
that referenced
this pull request
Jun 20, 2023
Add unit tests for the secrets service. Minor code changes to address redundancies, feedback from previous review. --------- Signed-off-by: Dako Dakov <ddakov@vmware.com> Co-authored-by: github-actions <> Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
murphp15
pushed a commit
that referenced
this pull request
Jun 21, 2023
Add unit tests for the secrets service. Minor code changes to address redundancies, feedback from previous review. --------- Signed-off-by: Dako Dakov <ddakov@vmware.com> Co-authored-by: github-actions <> Co-authored-by: Miroslav Ivanov <40535952+mivanov1988@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for the secrets service.
Minor code changes to address redundancies, feedback from previous review.