vdk-control-cli: download keytab along with downloading job #2617
Merged
duyguHsnHsn merged 23 commits intomainfrom Sep 4, 2023
Merged
vdk-control-cli: download keytab along with downloading job #2617duyguHsnHsn merged 23 commits intomainfrom
duyguHsnHsn merged 23 commits intomainfrom
Conversation
antoniivanov
suggested changes
Aug 29, 2023
projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/download_job.py
Outdated
Show resolved
Hide resolved
projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_download_job.py
Show resolved
Hide resolved
Contributor
antoniivanov
left a comment
antoniivanov
left a comment
There was a problem hiding this comment.
Please write meaningful description of the PR
antoniivanov
approved these changes
Sep 1, 2023
yonitoo
approved these changes
Sep 4, 2023
Contributor
yonitoo
left a comment
yonitoo
left a comment
There was a problem hiding this comment.
LGTM! Left a small suggestion.
projects/vdk-control-cli/tests/vdk/internal/control/command_groups/job/test_download_job.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added download keytab to download-job command
Why: Currently, the download-job command downloads a data job that is deployed in the Cloud without downloading its keytab. This functionality is provided by download-key but instead of doing 2 operations, a simpler approach for a user who wants to execute a Cloud deployed job locally would be to download both with one operation.
Testing: python unit tests
Signed-off-by: Duygu Hasan hduygu@vmware.com