vdk-core: add more unit tests to for job_input_error_classfier#2621
Merged
DeltaMichael merged 1 commit intomainfrom Sep 1, 2023
Merged
vdk-core: add more unit tests to for job_input_error_classfier#2621DeltaMichael merged 1 commit intomainfrom
DeltaMichael merged 1 commit intomainfrom
Conversation
DeltaMichael
force-pushed
the
person/mdilyan/improve-error-classifier-tests
branch
from
aeb4bcb to
ad234e7
Compare
antoniivanov
approved these changes
Aug 29, 2023
DeltaMichael
force-pushed
the
person/mdilyan/improve-error-classifier-tests
branch
from
ad234e7 to
71d3c20
Compare
Why? As part of the VDK Run Logs initiative, we should increase test coverage for the job_input_error_classifier What? Add unit test for error caused by external library used by vdk internal components Add unit test for error caused by passing custom iterator to job_input Add unit test for error caused by passing custom iterator using external libraries to job_input Tests that do not pass have been commented and appropriate ticket opened to address them #2620 How has this been tested? Ran unit tests locally What type of change are you making? New feature (non-breaking change which adds functionality) Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/improve-error-classifier-tests
branch
from
71d3c20 to
4c7e1d0
Compare
duyguHsnHsn
approved these changes
Sep 1, 2023
DeltaMichael
deleted the
person/mdilyan/improve-error-classifier-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
As part of the VDK Run Logs initiative, we should increase test coverage for the job_input_error_classifier
What?
Add unit test for error caused by external library used by vdk internal components
Add unit test for error caused by passing custom iterator to job_input
Add unit test for error caused by passing custom iterator using external libraries to job_input
Tests that do not pass have been commented and appropriate ticket opened to address them
#2620
Misc: Flip the assertion parameters passed, because they were the wrong way around.
How has this been tested?
Ran unit tests locally
What type of change are you making?
New feature (non-breaking change which adds functionality)