vdk-jupyter: show status on starting new operation#2627
Merged
antoniivanov merged 1 commit intomainfrom Aug 31, 2023
Merged
Conversation
Common usability issue with starting operations is that when you click the operation (e.g Run) nothing happens. This is fairly cheap temporary fix to at least show the status dialog and ask the user to explicitly close it. Longer term solution should be planned where we will not only show that operaiton is runnign, but show how long time it reemians, where it is currently (e.g what is in case of vdk run), show logs (if user wants to) and so on. But that's a bigger story.
DeltaMichael
approved these changes
Aug 31, 2023
Contributor
|
Can you add what happens if we click on the timer thing too after clicking ok |
Contributor
Author
The same thing as before: status-dialog-2.mov |
sabadzhiev
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common usability issue with starting operations is that when you click the operation (e.g Run) nothing happens.
This is fairly cheap temporary fix to at least show the status dialog and ask the user to explicitly close it.
Longer term solution should be planned where we will not only show that operaiton is runnign, but show how long time it reemians, where it is currently (e.g what is in case of vdk run), show logs (if user wants to) and so on. But that's a bigger story.
status-dialog.mp4