vdk-core: change jobs behavior when logging unavailable#2656
Merged
Conversation
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
antoniivanov
approved these changes
Sep 14, 2023
doks5
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what:
Data jobs won't fail if logging fails to initialize.
why:
If logging level is set to cloud and the configuration connects to an external service logging service such as log insight which happens to be unavailable to whole cloud cluster of data jobs will experience an outage. Instead of failing the data job, execution should now proceed with local logging on DEBUG level.
testing:
added unit test.