Merged
Conversation
Contributor
|
So the e2e tests would have caught it? Consider still adding smaller scope tests if it's not too hard. |
antoniivanov
approved these changes
Sep 26, 2023
gabrielgeorgiev1
approved these changes
Sep 26, 2023
Contributor
Author
We have tried it but there are some problems with some jupyter classes we need to use during testing with jest. They required full mocking of the hierarchy tree so that's why we ended up having only e2e tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fixed the conversion operation to add additional cell which runs the run function coming from .py step.
Before:
After:
Why:
To execute the python code in the function vdk-notebook requires it to be called (unlike how vdk generally works with .py steps).
The reason the bug was not caught is that it is only tested in the e2e tests and they are not yet added to the ci/cd.
Signed-off-by: Duygu Hasan hduygu@vmware.com