Merged
Conversation
DeltaMichael
force-pushed
the
person/mdilyan/remove-redundant-logs
branch
from
ea3a710 to
28b608f
Compare
gabrielgeorgiev1
approved these changes
Oct 27, 2023
DeltaMichael
force-pushed
the
person/mdilyan/remove-redundant-logs
branch
3 times, most recently
from
5042bcf to
67523b5
Compare
Why As part of the run logs initiative, we should audit all log statements and error messages in vdk-core and make sure there aren't any redundancies, e.g. overly verbose messages or messages that don't add value. What Remove MSG_CONSEQUENCE_DELEGATING_TO_CALLER__LIKELY_EXECUTION_FAILURE MSG_COUNTERMEASURE_FIX_PARENT_EXCEPTION MSG_CONSEQUENCE_TERMINATING_APP where possible Re-word log statements and exception messages that are too verbose How was this tested? CI What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/remove-redundant-logs
branch
from
67523b5 to
2f459c0
Compare
duyguHsnHsn
approved these changes
Nov 1, 2023
dakodakov
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As part of the run logs initiative, we should audit all log statements and error messages in vdk-core and make sure there aren't any redundancies, e.g. overly verbose messages or messages that don't add value.
What
Remove usage of the below constants wherever possible
Re-word log statements and exception messages that are too verbose
How was this tested?
CI
What kind of change is this?
Feature/non-breaking