control-service: add MeterRegistry counters for DataJobsSynchronizer#2844
control-service: add MeterRegistry counters for DataJobsSynchronizer#2844
Conversation
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
|
Can you please explain how is this going to be used ? Can you copy paste the new metrics generated from (/data-jobs/debug/prometheus) Have you thought of adding data job name as tag ? So it's easier to recognize which job's sync is failing. |
This will be used in a similar fashion to the DataJobExecutionCleanupMonitor. We already have metrics on a per job basis they can be found in DeploymentMonitor class and afaik work with the new synchronizer through the DeploymentProgress class. The purpose of this metric is to have visibility on successful dataJobsSynchrnize() invocations, rather than monitor individual data jobs' deployment statuses which is already present. A possible query might look like: |
what: added telemetry counters for the DataJobsSynchronizer
why: The counters can be used to monitor if the synchronizeDataJobs method is executing as expected.
testing: added unit test