Merged
Conversation
murphp15
changed the title
yonitoo
approved these changes
Nov 3, 2023
Contributor
yonitoo
left a comment
yonitoo
left a comment
There was a problem hiding this comment.
LGTM! What turned out to be the problem after all? I see we use a different image now. Was that it?
Contributor
Author
|
@yonitoo |
Contributor
|
I see that 3 jobs are skipped do we know the reason why? |
Contributor
Author
|
@duyguHsnHsn yeah I will fix that in a separate pr. I have the fix locally |
Contributor
|
@paul-dimitrov how do we get alerted for those? |
Contributor
Author
|
@duyguHsnHsn the gitlab job will be marked as a fail and it will be handle as normal? |
duyguHsnHsn
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We need to run jupyter tests in CICD to make sure there are no failures/regressions.
Please note i have commented out failing tests: #2870
How has this been tested?
Passing now.
In this PR I tested failures are reported as expected #2872