control-service: force aws cred provider refresh#2879
Merged
mivanov1988 merged 1 commit intomainfrom Nov 6, 2023
Merged
Conversation
Signed-off-by: mrMoZ1 <mzhivkov@vmware.com>
doks5
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what: Forced the AWS credentials service to refresh credentials before passing them to the data job builder task.
why: Users of the control-service noticed that the job builder task would occasionally fail with 401 unauthorized when attempting to push images to aws ecr repository. Since some builders take longer to build the images, it is possible that a passed valid credential expired during build. As per the aws documentation: "This credentials provider uses a background thread to refresh credentials." though it is unclear when credentials are rotated. Note this behaviour of the provider was changed in a aws update, previously the credentials were generated before every request.
testing: existing tests should cover this.