Skip to content

control-service: add support for pymssql#2908

Merged
mivanov1988 merged 1 commit intomainfrom
person/miroslavi/job-builder-support-for-pymssql
Nov 16, 2023
Merged

control-service: add support for pymssql#2908
mivanov1988 merged 1 commit intomainfrom
person/miroslavi/job-builder-support-for-pymssql

Conversation

@mivanov1988
Copy link
Copy Markdown
Contributor

Why
Currently, the base secure image does not contain the required libraries for pymssql Python package.

What
Installed required native dependencies.

Testing Done
Locally through the following command:

docker buildx build -f versatile-data-kit/projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk -t test-image-tag . --build-arg job_githash=localhsh1 --build-arg base_image=registry.hub.docker.com/versatiledatakit/data-job-base-python-3.9-secure:latest --build-arg job_name="data_job_name" --progress=plain

Signed-off-by: Miroslav Ivanov miroslavi@vmware.com

Why
Currently, the base secure image does not contain the required libraries for `pymssql` Python package.

What
Installed required native dependencies.

Testing Done
Locally through the following command:

```
docker buildx build -f versatile-data-kit/projects/control-service/projects/job-builder-secure/Dockerfile.python.vdk -t test-image-tag . --build-arg job_githash=localhsh1 --build-arg base_image=registry.hub.docker.com/versatiledatakit/data-job-base-python-3.9-secure:latest --build-arg job_name="data_job_name" --progress=plain
```

Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
@mivanov1988 mivanov1988 changed the title job-builder-secure: add support for pymssql control-service: add support for pymssql Nov 16, 2023
@mivanov1988 mivanov1988 force-pushed the person/miroslavi/job-builder-support-for-pymssql branch from 752b019 to a8f9d58 Compare November 16, 2023 07:29
Copy link
Copy Markdown
Collaborator

@dakodakov dakodakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@mivanov1988 mivanov1988 merged commit b739832 into main Nov 16, 2023
@mivanov1988 mivanov1988 deleted the person/miroslavi/job-builder-support-for-pymssql branch November 16, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants