Conversation
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
…se-log-level-module
Signed-off-by: Yoan Salambashev <ysalambashev@vmware.com>
Signed-off-by: Yoan Salambashev <yoan.salambashev@broadcom.com>
duyguHsnHsn
reviewed
Dec 20, 2023
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/constants.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
approved these changes
Dec 20, 2023
Signed-off-by: Yoan Salambashev <yoan.salambashev@broadcom.com>
gabrielgeorgiev1
approved these changes
Dec 21, 2023
yonitoo
deleted the
topic/ysalambashev/vdk-structlog-support-parse-log-level-module
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Transfer the log level functionality from the builtin logging config plugin to structlog and make it programmatic
Also, support adding loggers to the logging configuration via parse_log_level_module().
Why: In order to have this log level functionality as part of the structlog plugin in a more programmatic way.
Testing Done: existing tests pass, introduced relevant tests
Closes #2952
Signed-off-by: Yoan Salambashev yoan.salambashev@broadcom.com