vdk-structlog: rename structlog configs#3002
Merged
DeltaMichael merged 1 commit intomainfrom Jan 10, 2024
Merged
Conversation
Why? Structlog config options have the same name as some vdk-core config options. This causes a conflict when running jobs with minimal config. What? Rename the structlog config options How was this tested? Ran a hello-world example locally CI What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <mdilyan@vmware.com>
DeltaMichael
force-pushed
the
person/mdilyan/structlog-null-pointer
branch
from
5211c23 to
447f68e
Compare
duyguHsnHsn
approved these changes
Jan 9, 2024
murphp15
approved these changes
Jan 10, 2024
DeltaMichael
pushed a commit
that referenced
this pull request
Jan 10, 2024
Stacked on top of #3002 Solving: #2953 Tests: Unit tests for the function adding the configurations Signed-off-by: Duygu Hasan [hduygu@vmware.com](mailto:hduygu@vmware.com) --------- Signed-off-by: Dilyan Marinov <mdilyan@vmware.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dilyan Marinov <mdilyan@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Structlog config options have the same name as some vdk-core config options. This causes a conflict when running jobs with minimal config.
What?
Rename the structlog config options
How was this tested?
Ran a hello-world example locally
CI
What kind of change is this?
Bugfix