vdk-oracle: add new config options (host,port,sid,thick_mode_lib_dir)#3032
Merged
antoniivanov merged 1 commit intomainfrom Jan 17, 2024
Merged
vdk-oracle: add new config options (host,port,sid,thick_mode_lib_dir)#3032antoniivanov merged 1 commit intomainfrom
antoniivanov merged 1 commit intomainfrom
Conversation
DeltaMichael
approved these changes
Jan 17, 2024
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_configuration.py
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_connection.py
Show resolved
Hide resolved
yonitoo
approved these changes
Jan 17, 2024
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_configuration.py
Outdated
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/oracle-new-config
branch
from
035681e to
2465fd8
Compare
We are adding 3 options host,port,sid that were being originally added as part of PR #3019 The issue in the PR is that SID was incorrecctly passed as "service_name" to the underlying oracle db connect method. But it is actuall "SID" (system identifier) . Setting it correctly there works fine. I also had to add thick_mode_lib_dir since it was impossible to get thick mode working in Mac without passing it on. Testing Done: - added test_oracle_connect_execute_without_connection_string - tested in production environment against real (non local) with thick mode database with a data job which executed query and send data for ingestion successfully. Currently the automated tests do not cover the thick mode scenario due to extra setup required and this will be added later.
antoniivanov
force-pushed
the
person/aivanov/oracle-new-config
branch
from
2465fd8 to
80859e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding 3 options host,port,sid that were being originally added as part of PR #3019
The issue in the PR is that SID was incorrecctly passed as "service_name" to the underlying oracle db connect method. But it is actuall "SID" (system identifier) .
Setting it correctly there works fine.
I also had to add thick_mode_lib_dir since it was impossible to get thick mode working in Mac without passing it on.
Testing Done:
- added test_oracle_connect_execute_without_connection_string
- tested in production environment against real (non local) with
thick mode database with a data job which executed query and send data
for ingestion successfully.
Currently the automated tests do not cover the thick mode scenario due to extra setup required and this will be added later.