Skip to content

Procedure for creating custom vropkg sign certificate#117

Merged
llyubenova merged 1 commit intomasterfrom
feature/docs-vropkg-sign-certificate
Jan 23, 2023
Merged

Procedure for creating custom vropkg sign certificate#117
llyubenova merged 1 commit intomasterfrom
feature/docs-vropkg-sign-certificate

Conversation

@llyubenova
Copy link
Copy Markdown
Contributor

@llyubenova llyubenova commented Nov 18, 2022 •
edited
Loading

Description

Described procedure for creating custom vropkg sign certificate

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Screenshot

Related issues and PRs

@llyubenova llyubenova requested a review from a team as a code owner November 18, 2022 15:07
@vmwclabot
Copy link
Copy Markdown

vmwclabot commented Nov 18, 2022

@llyubenova, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Michaelpalacce
Michaelpalacce reviewed Jan 6, 2023
View reviewed changes
wiki/Setup-Developer-Workstation.md Outdated

`Note:` JKS is a propriatary format specific to the particular JVM provider. When running above commands, ensure the keytool used is the one under the JVM that Maven would use (check with `mvn -v`).
Example:
- artefact group ID: com.clientname.build
Copy link
Copy Markdown

@Michaelpalacce Michaelpalacce Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, should be artifact

Michaelpalacce
Michaelpalacce reviewed Jan 6, 2023
View reviewed changes
wiki/Setup-Developer-Workstation.md Outdated
# Generate new Key
keytool -genkey -keyalg RSA -keysize 2048 -alias _dunesrsa_alias_ -keystore package.jks -storepass 'VMware1!' -validity 3650 -dname 'CN=Project,OU=Department,O=Company,L=City,ST=State,C=XX,emailAddress=administrator@vsphere.local'
```sh
mkdir -p ~/cert/archetype.keystore-2.1.0
Copy link
Copy Markdown

@Michaelpalacce Michaelpalacce Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets give the example with version 1.0.0

@vmwclabot
Copy link
Copy Markdown

vmwclabot commented Jan 23, 2023

@llyubenova, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Copy Markdown

vmwclabot commented Jan 23, 2023

@llyubenova, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@llyubenova
Procedure for creating custom vropkg sign certificate
6297c66 
Signed-off-by: Liliya Lyubenova <llyubenova@vmware.com>
@llyubenova llyubenova force-pushed the feature/docs-vropkg-sign-certificate branch from 9f02720 to 6297c66 Compare January 23, 2023 13:23
@llyubenova llyubenova merged commit 9e4d47d into master Jan 23, 2023
@llyubenova llyubenova deleted the feature/docs-vropkg-sign-certificate branch January 23, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Michaelpalacce Michaelpalacce Michaelpalacce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llyubenova @vmwclabot @Michaelpalacce