Skip to content

[RunAction, logging] (#159) Restored System and Server logs in VRDT OUTPUT#160

Merged
bcpmihail merged 4 commits intomasterfrom
feature/159-restore-vrdt-output-logs
Oct 11, 2024
Merged

[RunAction, logging] (#159) Restored System and Server logs in VRDT OUTPUT#160
bcpmihail merged 4 commits intomasterfrom
feature/159-restore-vrdt-output-logs

Conversation

@bcpmihail
Copy link
Copy Markdown
Contributor

@bcpmihail bcpmihail commented Oct 10, 2024

Description

Restored System and Server logs in VRDT OUTPUT.
Fetching logs via API call depending on the configured Vrdev Log level in the plugin settings.
Requires changes to the Run Script XML WF in BTVA > packages > exec (see related PR).

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested by running a JS action (without return type and parameters) from a test project in:

  • VScode 1.94.1
  • BTVA 2.43.1-SNAPSHOT

Release Notes

Screenshot

vrdtOutputLogsOff
vrdtOutputLogsDebug
vrdtOutputLogsInfo

Related issues and PRs

VRDT issue: #159
Related BTVA PR: vmware/build-tools-for-vmware-aria#450

Signed-off-by: Mihail Penchev (c) <pmihail@vmware.com>
@bcpmihail bcpmihail added type:bug Something isn't working language:typescript TypeScript support issues priority:low Issue identified as low-priority labels Oct 10, 2024
@bcpmihail bcpmihail self-assigned this Oct 10, 2024
@bcpmihail bcpmihail requested a review from a team as a code owner October 10, 2024 15:11
@bcpmihail bcpmihail linked an issue Oct 10, 2024 that may be closed by this pull request
`?conditions=severity=${severity}` +
`&conditions=timestamp${encodeURIComponent(">")}${timestamp}` +
"&conditions=type=system"
`&conditions=timestamp${encodeURIComponent(">")}${timestamp}` // + "&conditions=type=system"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the commented condition, probably we won't need it anymore

VenelinBakalov and others added 3 commits October 11, 2024 10:34
Signed-off-by: Venelin Bakalov <bakalovv@vmware.com>
Signed-off-by: Mihail Penchev (c) <pmihail@vmware.com>
Signed-off-by: Mihail Penchev (c) <pmihail@vmware.com>
@bcpmihail bcpmihail requested a review from akantchev October 11, 2024 10:44
@bcpmihail bcpmihail merged commit 890b92d into master Oct 11, 2024
@bcpmihail bcpmihail deleted the feature/159-restore-vrdt-output-logs branch October 11, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

language:typescript TypeScript support issues priority:low Issue identified as low-priority type:bug Something isn't working type:enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Run vRO Action execution logs

2 participants