Skip to content

Run the language server only if there is an actions project in the workspace#60

Merged
nblagoev merged 1 commit intomasterfrom
feature/ls-on-actions-project-only
Feb 9, 2020
Merged

Run the language server only if there is an actions project in the workspace#60
nblagoev merged 1 commit intomasterfrom
feature/ls-on-actions-project-only

Conversation

@nblagoev
Copy link
Copy Markdown
Contributor

@nblagoev nblagoev commented Feb 6, 2020

Description

Run the language server only if there is an actions project in the workspace

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested using TypeScript project and a mixed project (js actions / workflows)

Related issues and PRs

#57

@nblagoev nblagoev requested a review from a team as a code owner February 6, 2020 14:20
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2020

Codecov Report

Merging #60 into master will decrease coverage by 0.21%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage    52.3%   52.09%   -0.22%     
==========================================
  Files          39       39              
  Lines         736      741       +5     
  Branches      100      101       +1     
==========================================
+ Hits          385      386       +1     
- Misses        351      355       +4

…rkspace

Signed-off-by: Nikolay Blagoev <blagoevn@vmware.com>
@nblagoev nblagoev force-pushed the feature/ls-on-actions-project-only branch from faceba8 to 0993de5 Compare February 6, 2020 14:41
@nblagoev nblagoev merged commit 3be7125 into master Feb 9, 2020
@nblagoev nblagoev deleted the feature/ls-on-actions-project-only branch February 9, 2020 13:15
VenelinBakalov added a commit that referenced this pull request Feb 11, 2026
[dependencies] (security alert #60, #61, #64) Fix `form-data`, `js-yaml` and `tmp` vulnerabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants