[release-1.14] fix: panic and restart of volcano scheduler pods on install#5144
Conversation
…rently create the `root` or `default` queue Signed-off-by: caotuo721 <caotuo721@yeah.net>
volcano-sh-bot
added
the
size/M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the newDefaultAndRootQueue function in pkg/scheduler/cache/cache.go to improve the robustness of queue creation. It now explicitly handles cases where a queue already exists by skipping creation instead of failing, and it ensures retries occur for other error types. Additionally, a new test suite TestNewDefaultAndRootQueue has been added to pkg/scheduler/cache/cache_test.go to verify concurrent queue creation scenarios. I have no feedback to provide.
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
volcano-sh-bot
merged commit b192ec4
into
volcano-sh:release-1.14
3 participants
This is an automated cherry-pick of #5077