[Bug] Bump SGLang version to 0.4.6.post4; Fix AsyncSGLangRollout #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
force-pushed
the
sglang_async
branch
2 times, most recently
from
767e144 to
97e49d4
Compare
HollowMan6
changed the title
plutoZZZZ
suggested changes
May 15, 2025
plutoZZZZ
approved these changes
May 15, 2025
vermouth1992
previously approved these changes
May 15, 2025
eric-haibin-lin
previously approved these changes
May 15, 2025
|
We will need to fix the CI and address the conflict |
Similar to sgl-project/sglang#5997 In the PP PR sgl-project/sglang#5724 broadcast_pyobj function changed its condition from judging rank==0 (if rank is local rank 0 of the passing ProcessGroup) to rank==src (if rank is global rank src), which breaks VerlEngine's broadcast logic when dp>1 and tp>1. Signed-off-by: Hollow Man <[email protected]>
Signed-off-by: Hollow Man <[email protected]>
|
Ah just noticed there is another bump pr here. Could you help take a look at whether your changes in |
|
Looks like everything is included in #1558, so close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Similar to sgl-project/sglang#5997
High-Level Design
In the PP PR sgl-project/sglang#5724 broadcast_pyobj function changed its condition from judging rank==0 (if rank is local rank 0 of the passing ProcessGroup) to rank==src (if rank is global rank src), which breaks VerlEngine's broadcast logic when dp>1 and tp>1.
Additional Info.
Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.