Add rule Handling Date/Time #5
Conversation
| @@ -633,6 +633,27 @@ log.error(f"An exception was thrown for value $value%.12f: $ex") | |||
|
|
|||
| Do not nest `map` more than twice. Use named values/functions instead. | |||
|
|
|||
| ## Handling Date And Time | |||
|
|
|||
| It is strongly recommended to use time library (either `java.time` or Joda Time) instead of doing calculations with milliseconds. As one implication of this rule, using System.currentTimeMillis()` is strongly discouraged and should not be used for time operations. | |||
There was a problem hiding this comment.
Kevin says: Please make a clear statement for when to use unix timestamp, and when to use date/time library. When serialize and store to DB, unix timestamp is the only choice with no exception. date/time library should only be used when cross-day time manipulation is required.
I intentionally used words like operations, arithmetic and calculations to stress that the usage of time library is strongly recommended in those cases. From my point of view, in Scala code unix time should never be used directly. Or can you give some example when using unix time in Scala code is justified? I can add an explicit mention about DB. |
|
good to merge |
|
I can't yet, there is no general agreement on this. |
No description provided.