Skip to content

Add vue/v-on-handler-style rule and deprecate vue/v-on-function-call rule #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 30, 2022
Merged

Add vue/v-on-handler-style rule and deprecate vue/v-on-function-call rule #2009

merged 18 commits into from
Oct 30, 2022
+1,951 −8

Conversation

ota-meshi
Copy link
Member

This PR adds vue/v-on-handler-style rule.
And deprecates vue/v-on-function-call rule.

close #2001

@ota-meshi ota-meshi requested a review from FloEdelmann October 12, 2022 04:53
@FloEdelmann FloEdelmann mentioned this pull request Oct 12, 2022
Closed
FloEdelmann
FloEdelmann requested changes Oct 12, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review without having looked at the code yet.

ota-meshi and others added 10 commits October 12, 2022 16:54
@ota-meshi @FloEdelmann
Update docs/rules/v-on-handler-style.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
56fd2e9 
Co-authored-by: Flo Edelmann <[email protected]>
@ota-meshi @FloEdelmann
Update docs/rules/v-on-handler-style.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f76cfad 
Co-authored-by: Flo Edelmann <[email protected]>
@ota-meshi
simplify element in doc
bc1f8c8
@ota-meshi
add related rules to doc
5bd54e9
@ota-meshi
add ignored examples to doc
e316a69
@ota-meshi
change to report morev
e9e9516
@ota-meshi
fix doc
194fe21
@ota-meshi
Merge branch 'master' into v-on-handler-style

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
cf2c89a
@ota-meshi
change v-on-handler-style
3395673
@ota-meshi
refactor
7296bc9
FloEdelmann
FloEdelmann requested changes Oct 20, 2022
View reviewed changes
ota-meshi and others added 4 commits October 26, 2022 17:59
@ota-meshi @FloEdelmann
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c0e2fe1 
Co-authored-by: Flo Edelmann <[email protected]>
@ota-meshi
update docs
b471fd3
@ota-meshi
fix error message
7134914
@ota-meshi
Merge branch 'master' into v-on-handler-style

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b5f4479
@ota-meshi
Copy link
Member Author

Thank you for your review.
I made a change to this PR other than ignoreIncludesComment.

FloEdelmann
FloEdelmann reviewed Oct 28, 2022
View reviewed changes
ota-meshi and others added 2 commits October 28, 2022 16:46
@ota-meshi @FloEdelmann
Update docs/rules/v-on-handler-style.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6fd394d 
Co-authored-by: Flo Edelmann <[email protected]>
@FloEdelmann
Merge branch 'master' into v-on-handler-style

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fb42bb5
FloEdelmann
FloEdelmann approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ LGTM

@ota-meshi ota-meshi merged commit f5d700c into master Oct 30, 2022
@ota-meshi ota-meshi deleted the v-on-handler-style branch October 30, 2022 14:26
This was referenced May 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edit v-on-function-call to enforce @click="() => fn()" over @click="fn()" and @click="fn"
2 participants
@ota-meshi @FloEdelmann