pre-commit hook ignores index

[noscript]

Version

3.0.0-beta.6

Reproduction link

https://github.com/noscript/vue-cli-pre-commit-bug

Steps to reproduce

• Create a project with Lint and fix on commit enabled
• Make some changes to src/App.vue and src/views/Home.vue
• Using git add -p select changes only from src/App.vue
• Commit with git commit

What is expected?

Only changes from src/App.vue committed.

What is actually happening?

Changes from src/views/Home.vue get committed too.

[dhensche]

see https://github.com/okonet/lint-staged#reformatting-the-code. I think support could be added to only commit the files already staged, but the file matcher for which files to lint is simply a file glob so all matched files will be linted. Also it looks like lint-staged still does not fully support partially staged files -- lint-staged/lint-staged#62

[yyx990803]

Closing as this is something that needs to be fixed in the upstream dependency.

[bodograumann]

Just stumbled upon this issue. I really think vue-cli should warn the user when selection “Lint and fix on commit”, that this will break the git workflow. Especially since all partially staged files will silently be commited as a whole!