Skip to content

case-insensitive on isActive property #3656

Open
@Kyle-Ye

Description

@Kyle-Ye

Version

3.5.3

Reproduction link

localhost/active-links/abouT

Steps to reproduce

What is expected?

The "/about" will be treated as active.

What is actually happening?

The "/about" is not treated as active.


Since Vue Router already supports case-insensitive matching for routes themselves. I think it should be the same for the active match to be case-insensitive too.

Activity

added a commit that references this issue on Oct 28, 2021
c8fc6d1
posva

posva commented on Oct 28, 2021

@posva
Member

Provide a valid repro please

Kyle-Ye

Kyle-Ye commented on Oct 28, 2021

@Kyle-Ye
Author

I think using a website like CodePen to build a minimal reproducible environment seems to be low-benifit and troublesome because we can directly use the existing example files(repo's /examples/activeLinks folder and so on) of the repo to reproduce. Just run yarn run dev(or node examples/server.js) and go to http://localhost:8080/active-links/abouT will reproduce the issue

added
fixed on 4.xThis issue has been already fixed on the v4 but exists in v3
and removed on Oct 28, 2021
posva

posva commented on Oct 28, 2021

@posva
Member

Aah, I couldn't guess you were talking about the repository examples!

Kyle-Ye

Kyle-Ye commented on Oct 28, 2021

@Kyle-Ye
Author

Aah, I couldn't guess you were talking about the repository examples!

Sorry that I didn't make it clear😂

added a commit that references this issue on Oct 29, 2021
bceff56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugfixed on 4.xThis issue has been already fixed on the v4 but exists in v3

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @posva@Kyle-Ye

      Issue actions

        case-insensitive on isActive property · Issue #3656 · vuejs/vue-router