Support offset/addr fields in aflj/afij and basic blocks #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping |
wargio
reviewed
May 11, 2025
js/libdec/r2util.js
Outdated
| var isfast = !r2pipe.bool('e r2dec.slow'); | ||
| this.arch = r2_arch(); | ||
| this.bits = r2pipe.int('e asm.bits', 32); | ||
| function aflj() { |
js/libdec/core/functions.js
Outdated
| } | ||
| return { | ||
| offset: x.offset, | ||
| offset: x.offset?? x.addr, |
js/libdec/core/functions.js
Outdated
| offset: x.offset?? x.addr, | ||
| name: x.name, | ||
| calltype: x.calltype, | ||
| calltype: x.calltype?? x.callconv, |
Owner
|
Looks like I never sent the comments. Sorry it's the stupid mobile github app. |
Contributor
Author
|
done. |
wargio
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have introduced some breaking changes in r2 structs and json objects. in this case offset is now named "addr" for function and basic blocks. im not sure if this is the most elegant way to handle that in r2dec, but that patch works with latest r2