Git Repositories #4
Conversation
Watch for updates to tracked GitRepositories and rereconcile.
| if err := mgr.GetCache().IndexField( | ||
| context.TODO(), &templatesv1.GitOpsSet{}, gitRepositoryIndexKey, indexGitRepositories); err != nil { | ||
| return fmt.Errorf("failed setting index fields: %w", err) | ||
| } |
There was a problem hiding this comment.
Interesting! Pure optimization or required to function?
There was a problem hiding this comment.
Ah, this is to start triggering reconciliations if the GitRepo's "change"
There was a problem hiding this comment.
|
|
||
| // NewRepositoryParser creates and returns a RepositoryParser. | ||
| func NewRepositoryParser(logger logr.Logger) *RepositoryParser { | ||
| return &RepositoryParser{fetcher: fetch.NewArchiveFetcher(retries, tar.UnlimitedUntarSize, tar.UnlimitedUntarSize, ""), Logger: logger} |
There was a problem hiding this comment.
| // Interval is an implementation of the Generator interface. | ||
| func (g *GitRepositoryGenerator) Interval(sg *templatesv1.GitOpsSetGenerator) time.Duration { | ||
| return generators.NoRequeueInterval | ||
| } |
There was a problem hiding this comment.
This might not actually be connected up to the controller-runtime yet? (which is fine for this generator)
There was a problem hiding this comment.
Actually, this might be a bug :-)
Lemme take a look
bigkevmcd
force-pushed
the
gitrepositories
branch
from
5220f14 to
257e9ad
Compare
| result = append(result, r) | ||
| } | ||
|
|
||
| return result, nil |
There was a problem hiding this comment.
is it useful to have the path too? maybe wait for a use case but could namespace the file contents? 🤔
The .element PR brought this to mind..
There was a problem hiding this comment.
Could be .elementSpec.path or something too if it would be useful to access that stuff.
Just musing.
There was a problem hiding this comment.
interesting idea...I like it...
.element.data and .element.path ?
There was a problem hiding this comment.
The .element idea is useful in context of repeat: ... because we can expose the repeating element as .repeat and the original element as .element which means you can still access bits of data from the surrounding generated element.
…com/fluxcd/image-reflector-controller/api-0.31.2 Bump github.com/fluxcd/image-reflector-controller/api from 0.31.1 to 0.31.2
This implements the first part of parsing from GitRepositories.