Test how URL parser handles domains with empty labels#5397
Merged
domenic merged 1 commit intoweb-platform-tests:masterfrom Apr 24, 2017
rmisev:patch-1
Merged
Test how URL parser handles domains with empty labels#5397domenic merged 1 commit intoweb-platform-tests:masterfrom rmisev:patch-1
domenic merged 1 commit intoweb-platform-tests:masterfrom
rmisev:patch-1
Conversation
The test covers https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 item: > 1. If part is the empty string, return input. Related issue: jsdom/whatwg-url#82
Collaborator
|
Notifying @Sebmaster, @annevk, @domenic, @mikewest, @rubys, @smola, @tomalec, @xiaojunwu, and @zcorpan. (Learn how reviewing works.) |
|
*This report has been truncated because the total content is 653732 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters). Firefox (nightly channel)Testing web-platform-tests at revision d4a8aaa All results7 tests ran/url/a-element-origin-xhtml.xhtml
/url/a-element-origin.html
|
Chrome (unstable channel)Testing web-platform-tests at revision d4a8aaa |
watilde
added a commit
to watilde/node
that referenced
this pull request
Apr 30, 2017
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397
watilde
added a commit
to nodejs/node
that referenced
this pull request
May 1, 2017
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397 PR-URL: #12707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
watilde
added a commit
to watilde/node
that referenced
this pull request
May 1, 2017
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Follow the spec of domainToASCII/domainToUnicode in whatwg, and synchronise WPT url test data. Refs: web-platform-tests/wpt#5397 PR-URL: nodejs#12707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test covers https://url.spec.whatwg.org/#concept-ipv4-parser 6.1 item:
Related issue: jsdom/whatwg-url#82
This change is