test: watch option snapshot #2679
Conversation
| .replace(/Hash: .*/gm, 'Hash: <hash>') | ||
| .replace(/Time: .*/gm, 'Time: <compile time>') | ||
| .replace(/Built at: .*/gm, 'Built at: <built time>'); | ||
| }; |
There was a problem hiding this comment.
Put normalizeCompileTime in normalizeV4Output, ideally we should have two function normalizeStatsV4 and normalizeStatsV5, v5 default output are simple so we should not have big problems here, If you need I can implement these functions so you will be able to continue adding snapshots and improve normalizeStats function using regexps
There was a problem hiding this comment.
yep help appreciated, also something wrong with v4 snapshot, thanks!
test/utils/test-utils.js
Outdated
| }; | ||
|
|
||
| const normalizeCompileTime = (output) => { | ||
| return output.replace(/in \d+ ms/gm, 'in <compile time> ms').replace(); |
There was a problem hiding this comment.
yep better to add an explanation and some examples of what's being replaced
|
Incident with GitHub Actions https://www.githubstatus.com/, the universe does not want to let me finish at all webpack-dev-server |
|
Actions are always painful 😞 |
|
@anshumanv Can you rebase, I want to finish, so we will continue migrate on snapshots |
|
on it |
|
@alexander-akait done :) |
|
We need do some improvements for |
What kind of change does this PR introduce?
test
Did you add tests for your changes?
it is test
If relevant, did you update the documentation?
NA
Summary
snapshot testing for watch option/command
Does this PR introduce a breaking change?
no
Other information