Update hot-module-replacement.md #1454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progressing through the tutorial so far, each tute lead on nicely to the next. This one however breaks the flow and provided no clues as to which lines to add like previous files do. I've marked up a couple of key ones that would be useful to highlight. This is helpful as is it is but could probably do with more work also.
|
|
|
Thanks for your contribution! We're actually in the process of rewriting this guide, as you can see in this PR I would suggest giving your input on that one if you like. I'll close this PR in the mean time ;) |
|
Ah excellent, I was hoping that was the case. Thanks for your ongoing work on this great project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progressing through the tutorial so far, each tute lead on nicely to the next.
This one however breaks the flow and provided no clues as to which lines to add like previous files do.
Basically the convention of the green lines beginning with + signs is not present in this file, breaking the flow of the tutorial at this point.
I've marked up a couple of key ones that would be useful to highlight.
This is helpful as is it is but could probably do with more work also.