feat: Soften duplicate contract name in the case contracts have identical ABIs #4695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundry seems to duplicate some imported sub-files within a contract, for example:
<foundry root>/src/parts/primitives/Foo.sol
Is defined only once, and imported from
<foundry root>/src/Bar.sol
But ends up appearing twice in artifacts directory:
In this case
getArtifactPaths()
in the Foundry plugin pick up the same contracts twice since they end up existing in multiple subdirectories ofout/
. I don't think there is a reliable to heuristic to de-duplicate them at this level.It seems like duck-typing contracts by the ABI should be fine and may help other plugin sources. it could always be disabled by default and enabled via an option at the cost of yet more config