Replace any with UserData interface for userData object construction

[warengonzaga]

🛠️ Refactor suggestion

User data object construction requires type safety enhancement.

Using any type for userData object construction bypasses TypeScript's benefits and could lead to runtime errors.

+interface UserData {
+  id: string;
+  telegramUserId: number;
+  unthreadName: string;
+  unthreadEmail: string;
+  createdAt: string;
+  updatedAt: string;
+  telegramUsername?: string;
+  username?: string;
+}

-const userData: any = {
+const userData: UserData = {
   id: `user_${telegramUserId}`,
   telegramUserId: telegramUserId,
   unthreadName: unthreadName,
   unthreadEmail: unthreadEmail,
   createdAt: new Date().toISOString(),
   updatedAt: new Date().toISOString()
};

if (username) {
-  userData.telegramUsername = username;
-  userData.username = username;
+  (userData as UserData & { telegramUsername: string; username: string }).telegramUsername = username;
+  (userData as UserData & { telegramUsername: string; username: string }).username = username;
}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

        // Define a proper UserData interface
        interface UserData {
            id: string;
            telegramUserId: number;
            unthreadName: string;
            unthreadEmail: string;
            createdAt: string;
            updatedAt: string;
            telegramUsername?: string;
            username?: string;
        }

        const userData: UserData = {
            id: `user_${telegramUserId}`,
            telegramUserId: telegramUserId,
            unthreadName: unthreadName,
            unthreadEmail: unthreadEmail,
            createdAt: new Date().toISOString(),
            updatedAt: new Date().toISOString()
        };
        
        if (username) {
            // Narrow the type so we know these optional props are set
            (userData as UserData & { telegramUsername: string; username: string }).telegramUsername = username;
            (userData as UserData & { telegramUsername: string; username: string }).username = username;
        }
        
        await BotsStore.storeUser(userData);

🤖 Prompt for AI Agents

In src/services/unthread.ts around lines 581 to 595, the userData object is
typed as any, which disables TypeScript's type checking and risks runtime
errors. Define a proper interface or type for the userData structure that
includes all expected properties like id, telegramUserId, unthreadName,
unthreadEmail, createdAt, updatedAt, and optional username fields. Then, replace
the any type with this specific type to ensure type safety and leverage
TypeScript's static checking.

Originally posted by @coderabbitai[bot] in #7 (comment)