Specify createTicket return type for improved type safety #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createTicket
function was returningPromise<any>
which undermined the type safety benefits of the TypeScript migration. This change introduces a proper return type interface to ensure strong typing.Changes Made
CreateTicketResponse
interface withid: string
andfriendlyId: string
propertiescreateTicket
function return type fromPromise<any>
toPromise<CreateTicketResponse>
createTicketJSON
function return type fromPromise<any>
toPromise<CreateTicketResponse>
Benefits
createTicket
function now have compile-time guarantees about the response structureExample Usage
The change is backward compatible and doesn't affect existing functionality - it only adds compile-time type safety.
Fixes #11.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.