-
-
Notifications
You must be signed in to change notification settings - Fork 2
[FR-287] Message Editing Support #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylergeorges
wants to merge
13
commits into
master
Choose a base branch
from
feat/message-editing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+189
−55
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a187958
fix: video embeds' proxy_url was not checked for null (#52)
JohnyTheCarrot 661b584
v2.3.1
JohnyTheCarrot f701474
fix: fix reaction style inaccuracy
JohnyTheCarrot 1f0a83f
feat: add MessageEditor component
tylergeorges bc1cf12
feat: handle EditMessageInput submit
tylergeorges c0fb0e2
feat: add editingMessageId prop to MessageRendererProvider
tylergeorges 172eb17
Update package.json
mason-rogers 015e982
refactor: remove commented style
tylergeorges b1f3d43
refactor: remove commented EditMessageInputProps
tylergeorges 758ba97
refactor: rename handleMessageEditSubmit
tylergeorges 244e90d
refactor: remove braces around autoCorrect prop
tylergeorges cb216fd
Merge remote-tracking branch 'origin' into feat/message-editing
tylergeorges 9ee22a5
Merge remote-tracking branch 'refs/remotes/origin/feat/message-editin…
tylergeorges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import React from "react"; | ||
import { useConfig } from "../../core/ConfigContext"; | ||
import type { ChatMessage } from "../../types"; | ||
|
||
import * as Styles from "../style/message"; | ||
|
||
interface EditMessageInputProps { | ||
message: ChatMessage; | ||
} | ||
|
||
function EditMessageInput(props: EditMessageInputProps) { | ||
const { messageEditOnSubmit } = useConfig(); | ||
|
||
function submitMessageCallback(content: string) { | ||
if (!messageEditOnSubmit || !content) return; | ||
|
||
messageEditOnSubmit({ | ||
...props.message, | ||
content: content, | ||
edited_timestamp: new Date().getMilliseconds().toString(), | ||
}); | ||
} | ||
|
||
function onKeyDown(e: React.KeyboardEvent<HTMLInputElement>) { | ||
const target = e.target as HTMLInputElement; | ||
|
||
if (e.key === "Enter") { | ||
submitMessageCallback(target.value); | ||
} | ||
} | ||
|
||
return ( | ||
<Styles.MessageEditor | ||
autoCorrect="false" | ||
onKeyDown={onKeyDown} | ||
defaultValue={props.message.content} | ||
/> | ||
); | ||
} | ||
|
||
export default EditMessageInput; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.