Skip to content

be more strict when crawling the stack #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2022
Merged

be more strict when crawling the stack #93

merged 5 commits into from
Dec 2, 2022

Conversation

wimglenn
Copy link
Owner

@wimglenn wimglenn commented Dec 1, 2022

additionally require that the line text in the stack frame contains "aocd" as a substring. should rule out false positives like in #92

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #93 (edfc9f6) into main (e66f0fe) will decrease coverage by 0.54%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   93.36%   92.81%   -0.55%     
==========================================
  Files          24       25       +1     
  Lines        2094     2143      +49     
  Branches      266      272       +6     
==========================================
+ Hits         1955     1989      +34     
- Misses        111      125      +14     
- Partials       28       29       +1     
Impacted Files Coverage Δ
aocd/_ipykernel.py 22.22% <22.22%> (ø)
aocd/get.py 96.93% <94.44%> (-0.77%) ⬇️
aocd/__init__.py 100.00% <100.00%> (ø)
aocd/version.py 100.00% <100.00%> (ø)
tests/test_aocd.py 100.00% <100.00%> (ø)
tests/test_date_introspection.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wimglenn wimglenn merged commit a7c5824 into main Dec 2, 2022
@wimglenn wimglenn deleted the stack branch December 2, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant