-
Notifications
You must be signed in to change notification settings - Fork 4
Automatically download and update PowerShell Editor Services for LSP #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Formatting is working. |
Closes #8 |
I gave this a whirl on macOS, it managed to install/start PowerShell Editor Services properly. Nice! I also took a stab at some basic docs which we can publish once this is broadly available. Let me know if I can be of assistance getting this merged and an updated version published in the Zed Extension store. |
Bump @wingyplus |
[ | ||
"begin" | ||
"break" | ||
"catch" | ||
"class" | ||
"clean" | ||
; "clean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to comment this out on this PR. Let's fix the highlights.scm to make it work again on another PR.
@oWretch @notpeter Sorry for the silence for a long time. I have been really busy this year. :( This PR LGTM to me. So I'm going to merge it. But before we release a new version, I need someone to fix & sync highlights.scm from upstream to make it work again. Anyone interested in tackling this issue? |
Download Editor Services and cache, checking for updates as required.
To get v0.2.0 to compile, I had to comment out some keywords in
highlights.scm
as they prevented the compiled extension from loadingclean
define
from
using
var
I tried updating to the latest grammar version, but this didn't help.
Closes #2
Closes #6
Closes #8