Work-around / fix libasan incompatibility #389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing #365. I cleaned up the proposed patch from there and actually simplified it a bit. I also added a unit test that would previously hang (deadlock in
pthread_mutex_lock()
) and now passes.As requested, this adds a new define. I chose to call it
FAIL_PRE_INIT_CALLS
. I also had to enable it by default since otherwise the test would hang. I kind of expect this to be an unsatisfactory solutions. Please advice how to properly integrate this test (or whether it should just be deleted).I did test that this makes the hang with both
clang -fsanitize=address main.c
andclang++ -fsanitize=address main.cpp
go away (wheremain.c(pp)
is just an empty main function). I also checked that without this changes, the resulting programs would hang under faketime.Fixes #365
Edit: Also, I was lazy and just failed all calls before
ftpl_init()
, not only duringftpl_init()
. That's different to the previous hacky patch.