Fix instrumentation tests execution #1105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pm` is less effective, according to logs
It's default test device on FTL
… assert focus, add a delay, close the keyboard
They seem to interfere with instrumented the tests execution
It'll happen whenever Espresso waited for too long for an input
wzieba
commented
Jun 13, 2025
Comment on lines
+36
to
+46
| threadSleep(2000L) // Wait for the page to load | ||
| try { | ||
| urlField.perform(click()) | ||
| urlField.perform(replaceText(url), ViewActions.closeSoftKeyboard()) | ||
| } catch (e: RuntimeException) { | ||
| // If the URL field is not visible, it might be because the keyboard is open. | ||
| // Close the keyboard and try again. | ||
| urlField.perform(ViewActions.closeSoftKeyboard()) | ||
| urlField.perform(replaceText(url), ViewActions.closeSoftKeyboard()) | ||
| e.printStackTrace() | ||
| } |
There was a problem hiding this comment.
This is the core change: a few of additional safety checks and delays to make UI tests not flaky on CI.
| @@ -46,7 +45,6 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| android:gravity="top|start" | |||
| android:hint="@string/source_hint" | |||
There was a problem hiding this comment.
The android:hint looked quite strange on the device when running tests: almost like a normal test. After removing them, tests started to pass. I'm not entirely sure why (as they were flaky and the failure was not reproducible locally), so here's my best guess.
I think that's fair as it only affects the test app.
|
eh, I don't know, the tests are still flaky on Firebase Test Lab - I can't reproduce the problem locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes instrumented tests execution by updating model to the new default.
Previously used, Pixel 2, has been decommissioned.
To check all available devices, you can use
gcloud firebase test android models listTesting
Green CI means we're good to go.
Or, if you wish, you can run
.buildkite/commands/connected-tests.shlocally (apply secrets before) and wait for the result.After the latest changes, I've run tests 3 times on Firebase, and they passed each time.