Skip to content

fix: Prevent block inserter horizontal overflow #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

dcalhoun
Copy link
Member

What?

Prevent horizontal scrolling in the block inserter.

Why?

The horizontal scrollbar is unnecessary, as the intended content should
only scroll vertically. Fix CMM-345. Fix #121.

How?

Override core-provided, inline styles for the popover component.

Testing Instructions

  1. Open the block inserter.
  2. Explore various tabs and Attempt to scroll.
  3. Verify content is accessible as expected, but horizontal scrolling does not
    occur.

Accessibility Testing Instructions

Content navigation should remain the same as before.

Screenshots or screencast

N/A, no visual changes.

The horizontal scrollbar is unnecessary, as the intended content should
only scroll vertically.
@dcalhoun dcalhoun added the [Type] Bug An existing feature does not function as intended label May 13, 2025
@dcalhoun dcalhoun marked this pull request as ready for review May 13, 2025 14:46
@dcalhoun dcalhoun requested a review from jkmassel May 13, 2025 14:46
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a 13" iPad Simulator with Stage Manager (which was the context of the original report).

I could no longer reproduce the issue.

@dcalhoun dcalhoun merged commit 7ad8491 into trunk May 13, 2025
10 checks passed
@dcalhoun dcalhoun deleted the fix/prevent-block-inserter-horizontal-overflow branch May 13, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block inserter can scroll horiztonally
2 participants