Skip to content

build: Update @wordpress/block-editor patch #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

dcalhoun
Copy link
Member

What?

Update @wordpress/block-editor patch.

Why?

Address the following warning logged while running npm install:

Warning log
patch-package 8.0.0
Applying patches...
@wordpress/[email protected] ✔

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    @wordpress/[email protected]

  applied to

    @wordpress/[email protected]

  At path

    node_modules/@wordpress/block-editor

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package @wordpress/block-editor

  to update the version in the patch file name and make this warning go away.

---
patch-package finished with 1 warning(s).

How?

Run npx patch-package @wordpress/block-editor.

Testing Instructions

N/A, no user-facing changes.

Accessibility Testing Instructions

N/A, no user-facing changes.

Screenshots or screencast

N/A, no user-facing changes.

Address the following error logged while running `npm install`:

```
patch-package 8.0.0
Applying patches...
@wordpress/[email protected] ✔

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    @wordpress/[email protected]

  applied to

    @wordpress/[email protected]

  At path

    node_modules/@wordpress/block-editor

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package @wordpress/block-editor

  to update the version in the patch file name and make this warning go away.

---
patch-package finished with 1 warning(s).
```
@dcalhoun dcalhoun added the [Type] Build Tooling Issues or PRs related to build tooling label May 14, 2025
@dcalhoun dcalhoun marked this pull request as ready for review May 14, 2025 19:12
@dcalhoun dcalhoun enabled auto-merge (squash) May 14, 2025 19:12
@dcalhoun dcalhoun requested a review from nbradbury May 14, 2025 19:13
@nbradbury nbradbury self-assigned this May 14, 2025
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I pulled this branch and:

  • Ran make build
  • Ran npx patch-package @wordpress/block-editor
  • Ran npm install
  • Didn't see the patch version mismatch warning

:shipit:

@dcalhoun dcalhoun merged commit bd26c73 into trunk May 14, 2025
10 checks passed
@dcalhoun dcalhoun deleted the build/update-wordpress-block-editor-patch branch May 14, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants