fix: Scrolling along edges breaks text editing #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing Gutenberg `preventFocusCapture` logic relies upon `pointerdown` and `pointerup` events for temporarily disabling all text blocks `contenteditable` status. This is down to mitigate issues with block selection for `flex` elements. However, `pointerup` events are not always triggered on touch devices when a touch turns into a swipe. When you scroll with your finger outside of the block canvas, the `pointerup` callback is never invoked. Scrolling twice or more leads to a stale `value` in the callback, and a state where `contenteditable` is perpetually disabled.
nbradbury
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix perpetually disabled text blocks after scrolling the editor by swiping
outside of the block canvas container.
Why?
Fix CMM-356. The inability to edit text is unexpected.
How?
Existing Gutenberg
preventFocusCapturelogic relies uponpointerdownand
pointerupevents for temporarily disabling all text blockscontenteditablestatus. This is done to mitigate issues with blockselection for
flexelements.However,
pointerupevents are not always triggered on touch deviceswhen a touch turns into a swipe. When you scroll with your finger
outside of the block canvas, the
pointerupcallback is never invoked.Scrolling twice or more leads to a stale
valuein the callback, and astate where
contenteditableis perpetually disabled.Testing Instructions
block canvas that contains the blocks.
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.