fix: Embed renders #140
Merged
fix: Embed renders #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous allow list approach meant one-off requests were often sent to the OS browser. E.g., a YouTube embed launched the OS browser rather than displaying the embedded video within the editor.
This class is typically added by WordPress core when a theme enables the `responsive-embeds` feature. Enabling it seems like a sounds default for the mobile editor. Otherwise, content will not resize and overflow. https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-support/#responsive-embedded-content
This is host specific code that should be hoisted to the host app.
The `src/utils/api-fetch.js` utility now imports `@wordpress/url`. To prevent Vite from attempting to externalize that import, we must check if the `module` (i.e., the matched import syntax) is one of the modules that should not be externalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix broken embed rendering.
Why?
Embeds unexpectedly launched the iOS browser rather than rendering.
Additionally, embed sizing was incorrect due to missing
bodyclass andwrapping elements.
Fix CMM-287.
How?
Update iOS WebView request handling logic to only open link-activation requests
in the OS browser.
Add required
bodyclass for responsive embeds. See https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-support/#responsive-embedded-content.Add host-specific logic for removing wrapping elements from embed renders.
Testing Instructions
Tip
When testing iOS, use the prototype build: wordpress-mobile/WordPress-iOS#24556
1: Embeds can be created
2: Opening a post with an embed renders the embed
Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
N/A, no visual changes.