Skip to content

Revert to AGP 8.7.3 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Revert to AGP 8.7.3 #143

merged 1 commit into from
May 28, 2025

Conversation

nbradbury
Copy link
Contributor

As a companion to this WPAndroid PR, this PR reverts AGP to v8.7.3. Please refer to that WPAndroid PR for details.

@nbradbury nbradbury added the [Type] Regression Related to a regression in the latest release label May 28, 2025
@nbradbury nbradbury requested a review from Copilot May 28, 2025 13:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the Android Gradle Plugin version to 8.7.3 to align with a companion WPAndroid PR.

  • Reverting AGP from 8.8.1 to 8.7.3
  • Maintaining compatibility with the referenced WPAndroid changes

@nbradbury nbradbury requested a review from dcalhoun May 28, 2025 14:09
@nbradbury nbradbury marked this pull request as ready for review May 28, 2025 14:09
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested running the following and all functioned as expected:

  • The GBK Demo app.
  • WP-Android with a GBK composite build.
  • WP-Android with a GBK binary depedency.
  • ./gradlew assembleRelease.
  • ./gradlew lintRelease

I note that the previous Gradle upgrade included additional file changes:

  • android/gradle/wrapper/gradle-wrapper.jar
  • android/gradle/wrapper/gradle-wrapper.properties
  • android/gradlew
  • android/gradlew.bat

I presume we do not need to make similar changes, but @ParaskP7 will you confirm?

@nbradbury nbradbury merged commit 709dd55 into trunk May 28, 2025
11 checks passed
@nbradbury nbradbury deleted the issue/revert-agp-to-8.7.3 branch May 28, 2025 15:07
@ParaskP7
Copy link
Contributor

I presume we do not need to make similar changes, but @ParaskP7 will you confirm?

You're right @nbradbury , no need to do any Gradle up/downgrade with this change, downgrading and thus touching AGP only should be all we need from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants