-
Notifications
You must be signed in to change notification settings - Fork 250
[Depends][Bento4] Cleanups to remove some patches #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Piers
Are you sure you want to change the base?
Conversation
Most rilevant change, add our implementation of ReadGolomb in order to remove bento4 custom patch
Added to remove bento4 custom patch
This allow to remove custom bento4 changes
bc1030f
to
612a45d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up custom patches to reduce commit volume by removing obsolete modifications from the custom Bento4 fork. Key changes include:
- Adding a new constant (MP4_SAMPLE_FORMAT_WVTT) and a helper class (MP4UnknownUuidAtom) to expose atom data.
- Refactoring type casting in ParseTrafTfrf from a dynamic_cast to a static_cast.
- Removing unused member variables from CodecHandler and updating dependency references in the Bento4 configuration files.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/samplereader/FragmentedSampleReader.cpp | Introduces MP4_SAMPLE_FORMAT_WVTT and refactors type casting in ParseTrafTfrf. |
src/codechandler/CodecHandler.h | Cleans up member variables and modernizes the destructor. |
src/codechandler/AVCCodecHandler.h & .cpp | Adjusts picture ID handling and streamlines slice header parsing logic. |
depends/common/bento4/* | Updates dependency URLs and checksums for Bento4. |
@@ -505,7 +515,7 @@ void CFragmentedSampleReader::UpdateSampleDescription() | |||
|
|||
void CFragmentedSampleReader::ParseTrafTfrf(AP4_UuidAtom* uuidAtom) | |||
{ | |||
const AP4_DataBuffer& buf{AP4_DYNAMIC_CAST(AP4_UnknownUuidAtom, uuidAtom)->GetData()}; | |||
const AP4_DataBuffer& buf{static_cast<MP4UnknownUuidAtom*>(uuidAtom)->GetData()}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a runtime type check or a static_assert to ensure that 'uuidAtom' is indeed an instance of MP4UnknownUuidAtom before using static_cast. This will help prevent potential issues if the input object is not of the expected type.
const AP4_DataBuffer& buf{static_cast<MP4UnknownUuidAtom*>(uuidAtom)->GetData()}; | |
auto* unknownUuidAtom = dynamic_cast<MP4UnknownUuidAtom*>(uuidAtom); | |
if (!unknownUuidAtom) | |
{ | |
LOG::LogF(LOGERROR, "Invalid atom type passed to ParseTrafTfrf. Expected MP4UnknownUuidAtom."); | |
return; | |
} | |
const AP4_DataBuffer& buf{unknownUuidAtom->GetData()}; |
Copilot uses AI. Check for mistakes.
Description
Cleanups to remove some patches
i try waiting an answer of the maintainer on axiomatic-systems/Bento4#977
to understand what changes to be included or not on our bento4 repo
Motivation and context
A bit less commits to maintains on our custom bento4
How has this been tested?
Already tested on android also to check DolbyDigital+ bento4 regression (recently fixed)
Screenshots (if appropriate):
Types of change
Checklist: