Cannot move source.tmp when installing package from git

[Cutano]

Xmake Version

v2.7.1

Operating System Version and Architecture

Windows 11 22H2

Describe Bug

error: cannot move source.tmp to source Permission denied

Expected Behavior

Deps installed successfully.

Project Configuration

No response

Additional Information and Error Logs

No response

[waruqi]

you can add -vD and let me see full logs.

xmake f -c -vD

[Cutano]

Thanks for the reply!
Here's the full logs:

[Cutano]

Here's another log when I use particular version of ImGui:

[waruqi]

I don't know, maybe some other process is accessing this directory, you can check it. %localappdata%/.xmake/cache/... /source.tmp

[Cutano]

It seems that the problem is associated with Git. I cleared my Git config then reinstalled it, and it's fine.

[xq114]

Please reopen this issue. I just ran into the same issue; I'm wondering why xmake clone a repository to source.tmp instead of copying it directly into source?

xmake/xmake/modules/private/action/require/impl/actions/download.lua

Lines 78 to 102 in 4139d07

	packagedir = path.join(sourcedir .. ".tmp", package:name())
	if package:branch() then
	-- only shadow clone this branch
	git.clone(url, {depth = 1, recursive = true, longpaths = longpaths, branch = package:branch(), outputdir = packagedir})
	-- download package from revision or tag?
	else
	-- clone whole history and tags
	git.clone(url, {longpaths = longpaths, outputdir = packagedir})
	-- attempt to checkout the given version
	local revision = package:revision(url_alias) or package:tag() or package:commit() or package:version_str()
	git.checkout(revision, {repodir = packagedir})
	-- update all submodules
	if os.isfile(path.join(packagedir, ".gitmodules")) then
	git.submodule.update({init = true, recursive = true, longpaths = longpaths, repodir = packagedir})
	end
	end
	-- move to source directory
	os.rm(sourcedir)
	os.mv(sourcedir .. ".tmp", sourcedir)

I think it does nothing but making more errors, since git could occupy this folder, and the performance would suffer from the useless copying.

[SirLynix]

and the performance would suffer from the useless copying

Moving a folder on the same disk is a very fast operation, it doesn't involve copying.

My theory on this error is that git is still using the folder after cloning it on some configs, maybe to index it, so it locks the .tmp folder preventing it to be moved.

[waruqi]

os.mv is very fast, and normally, source.tmp should only be occupied by one git process, and it will stop occupying this directory as soon as git clone finishes. Unless the git process or its child processes have not fully exited after git clone has finished and continue to occupy it.

The use of source.tmp is to ensure the integrity of the source directory, so that even if git is killed during the clone process, there will not be an incomplete source directory.

[SirLynix]

maybe xmake could try to move it multiple times if it fails, waiting a bit between tries until it reaches a max_tries value.

[waruqi]

But I need to know the root cause, why the git clone process exits and source.tmp continues to be occupied.

[Cutano]

os.mv is very fast, and normally, source.tmp should only be occupied by one git process, and it will stop occupying this directory as soon as git clone finishes. Unless the git process or its child processes have not fully exited after git clone has finished and continue to occupy it.

I have tried rebooting and build directly after that, there should be no process occupied, but failed with the same issue.

[SirLynix]

I have tried rebooting and build directly after that, there should be no process occupied, but failed with the same issue.

if that operation failed xmake will clone it again with git, causing the same issue.

If someone successfully reproduces this issue, it would be nice to use a software like https://lockhunter.com to quickly check what processes lock the .tmp folder