feat!: switch from CJS to ESM and bump Yeoman packages#269
feat!: switch from CJS to ESM and bump Yeoman packages#269JoshuaKGoldberg wants to merge 11 commits intoyeoman:mainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
jestjs/jest#14923, which is now newly available in Jest 30 (still in alpha). Fun timing. |
|
@mshima I'm having a hard time here. Could I ask for your help, please? What I'm trying to do is get
|
|
Looks like jest doesn’t support 'node:test' module. |
Interesting. For visibility, looking at the error in the CI logs: That's in import { mock } from 'node:test';...which comes from yeoman/yeoman-test#232: "switch to mock from node:test". Which I'm in the dark on. What was the context there? Should we be switching all tests from Jest to |
Purpose of this pull request?
Fixes #265.
What changes did you make?
"type": "module"to the package.jsonyeoman-generatorandyosaypackage.jsonandbuild.ymlNode.js versions to 18+Is there anything you'd like reviewers to focus on?
I opted not to update other dependencies such as Chalk to keep the change minimal. I'd suggest we hold off releasing a new major version with these changes until those come in too.
BREAKING CHANGE: Updates the Node.js engine minimum to
^18.17.0 || >=20.5.0to align with the current"yeoman-generator"minimums.