Handle null partition keys in a bound statement #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sfurti-yb
approved these changes
Feb 3, 2025
|
Test case added here: ashetkar/yugabyte-db#1. Can be merged only after the driver is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PartitionAwarePolicydoes not expect null values for the partition key in bound statements.But null values could be set for partition keys by mistake and that should not cause NPEs coming from the driver.
Nulls are handled simply by falling back to the
YugabyteDefaultLoadBalancingPolicy.Testing
Test case added here: ashetkar/yugabyte-db#1