Skip to content

Cleanups to implementation of create() #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 3, 2025

This cleans up the implementation of create() a bit by:

  • Fixing the typing of filters
  • Removing duplicate parsing of data type and compressor (the parsing is already done further down the call stack)
  • Moving the parsing of filters to be in the same place (further down the call stack) as parsing of compressor

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 3, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Jun 3, 2025

thank you for this cleanup work 🙏

@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2025
@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 9, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 17, 2025
@dstansby dstansby requested a review from d-v-b June 17, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants