Use the alt modifier when going to a definition with cmd-click
#38148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
timvermeulen
force-pushed
the
alt-modifier-cmd-click
branch
2 times, most recently
from
026eb57 to
f944a7f
Compare
timvermeulen
force-pushed
the
alt-modifier-cmd-click
branch
from
f944a7f to
ae86b88
Compare
|
Thank you! |
rtfeldman
pushed a commit
that referenced
this pull request
Oct 2, 2025
) I don't totally follow how the `cmd_click_reveal_task` function works, but it branches on whether `self.hovered_link_state` exists and contains any links, and in case it doesn't, it doesn't use `modifiers.alt` for deciding where to navigate. This PR addresses that. The problem I've been having is that cmd-alt-click sometimes behaves as cmd-click, i.e. it navigates to the definition in the current pane. This appears to happen whenever I cmd-alt-click while the symbol I'm hovering over isn't underlined, possibly when I click too quickly? An alternative way to reliably reproduce this is to cmd-alt-click on a symbol without letting go of cmd and alt and without moving the cursor. Now the symbol is no longer underlined (and the hover preview has disappeared as well), so clicking again (while still holding cmd and alt) goes to the definition in the current pane: https://github.com/user-attachments/assets/34003e01-fd95-4741-8a7d-6240d1c5a495 Release notes: - Fixed a bug that caused cmd-alt-click to sometimes go to the definition in the current pane Co-authored-by: Joseph T. Lyons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't totally follow how the
cmd_click_reveal_taskfunction works, but it branches on whetherself.hovered_link_stateexists and contains any links, and in case it doesn't, it doesn't usemodifiers.altfor deciding where to navigate. This PR addresses that.The problem I've been having is that cmd-alt-click sometimes behaves as cmd-click, i.e. it navigates to the definition in the current pane. This appears to happen whenever I cmd-alt-click while the symbol I'm hovering over isn't underlined, possibly when I click too quickly?
An alternative way to reliably reproduce this is to cmd-alt-click on a symbol without letting go of cmd and alt and without moving the cursor. Now the symbol is no longer underlined (and the hover preview has disappeared as well), so clicking again (while still holding cmd and alt) goes to the definition in the current pane:
cmd-alt-click.mov
Release notes: